[Hexagon] Pytestify Hexagon unit test #8955
Conversation
kparzysz-quic
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen,
yzhliu and
zhiics
as code owners
| hexagon.register_linker(lambda: "/bin/true") | ||
| return True | ||
| # Register a phony linker, so that we can test codegen without a Hexagon toolchain. | ||
| hexagon.register_linker(lambda: "/bin/true") |
There was a problem hiding this comment.
should this become a fixture and unregister on test exit?
There was a problem hiding this comment.
Yeah, that would be cleaner.
There was a problem hiding this comment.
One problem is that if all of these tests run from a common "super"-module, and are executed in parallel, then the linker may get unregistered by one test before the other tests are done using it. Right now this is the only tests that does this, but if there are more added later, then it may become an issue.
Another thing may be that we may want to do lazy linking in Hexagon module, so that we're not looking for the linker each time when tvm.build is executed...
There was a problem hiding this comment.
pytest-xdist will spawn new sys.executable to distribute the load, so shouldn't need to worry about refcounting here. the fixture should be enough. i am going to push on the xdist PR again soon, which is why i ask :). do you mind making the change here? it's not too complicated--just @pytest.fixture around a local function, move the register call there, and take the function name as an argument to each test_
There was a problem hiding this comment.
I've turned it into a fixture.
jroesch
removed request for
yzhliu,
tqchen,
zhiics,
comaniac,
merrymercy and
junrushao
|
@kparzysz-quic does my request seem reasonable to you? |
|
I added the |
There was a problem hiding this comment.
thanks @kparzysz-quic ! please resubmit as the CI is fixed.
* [Hexagon] Pytestify Hexagon unit test * Fix formatting * Convert linker registration into pytest fixture * Use yield in pytest fixture * Restart CI
* [Hexagon] Pytestify Hexagon unit test * Fix formatting * Convert linker registration into pytest fixture * Use yield in pytest fixture * Restart CI
No description provided.