[Relay][UnitTest] Removed redundant unit test. #8993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
|
What about tvm/tests/python/relay/test_any.py Line 375 in 6dea994 and tvm/tests/python/relay/test_any.py Line 435 in 6dea994 ? |
|
That one should also be removed, and I will update the PR. Looks like I didn't find it in my initial search because |
test_op_level2.py::test_conv2d and test_any.py::test_any_reduce should have been removed in the refactoring in apache#8947. All functionality tested by it is in test_op_level2.py::TestConv2D and test_any::TestAnyReduce.
Lunderberg
force-pushed
the
test_conv2d_relay
branch
from
fa28fd2
to
334ec48
Compare
masahi
approved these changes
Sep 13, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
test_op_level2.py::test_conv2d and test_any.py::test_any_reduce should have been removed in the refactoring in apache#8947. All functionality tested by it is in test_op_level2.py::TestConv2D and test_any::TestAnyReduce.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
test_op_level2.py::test_conv2d and test_any.py::test_any_reduce should have been removed in the refactoring in apache#8947. All functionality tested by it is in test_op_level2.py::TestConv2D and test_any::TestAnyReduce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_op_level2.py::test_conv2d should have been removed in the refactoring in #8947. All functionality tested by it is in test_op_level2.py::TestConv2D.