Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microTVM][Zephyr] Fix board names #8998

Merged
merged 3 commits into from Sep 14, 2021
Merged

Conversation

mehrdadh
Copy link
Member

This PR fixes some of the board names left out from recent refactor: #8940

@mehrdadh
Copy link
Member Author

cc @areusch @gromero

Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a bunch of other locations--can you do a quick grep?

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think long term, it would be beneficial to spot duplicates if we keep as much as possible, the lists of boards alphabetically sorted. What do you think?

@areusch
Copy link
Contributor

areusch commented Sep 14, 2021

@leandron i agree. let's merge this now and we can alphabetize in a follow-up

@areusch areusch merged commit ff4bf3b into apache:main Sep 14, 2021
@mehrdadh mehrdadh deleted the zephyr_fix_board_name branch September 14, 2021 15:45
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* fix board names

* fix base_box test

* fix tutorial
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* fix board names

* fix base_box test

* fix tutorial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants