Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support match pvar with dtype constraint #9016

Merged
merged 2 commits into from
Sep 19, 2021
Merged

Support match pvar with dtype constraint #9016

merged 2 commits into from
Sep 19, 2021

Conversation

wrongtest-intellif
Copy link
Contributor

This PR add two helper class for tir expression pattern match.

  • PVarWithType works same as PVar with dtype match
  • PVecType represent a wildcard vec type placeholder same as PVar<DataType>, but with element dtype match
PVecType vec_ph(DataType::Float(32));
PVarWithType<PrimExpr, arith::PVecType> pat(vec_ph);
if (pat.Match(expr)) { ... }

// equaivalent to
PVar<PrimExpr> pat;
if (pat.Match(expr)) {
   PrimExpr x = pat.Eval();
   if (x->dtype == DataType::Float(32)) { ... }
}

@junrushao
Copy link
Member

CC @spectrometerHBH @tqchen @Hzfengsy would you guys review this patch?

tqchen
tqchen reviewed Sep 17, 2021
View reviewed changes
Copy link
Member

@tqchen tqchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, two minor comments on naming. Thanks @wrongtest

src/arith/pattern_match.h Outdated
*/
template <typename T, typename DType,
typename = std::enable_if<std::is_base_of<T, PrimExpr>::value>>
class PVarWithType : public PVarWithCheck<PVarWithType<T, DType>, T> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to rename to PVarWithDataType

src/arith/pattern_match.h Outdated
/*!
* \brief Pattern variable container for data type with lanes.
*/
class PVecType : public PVarWithCheck<PVecType, DataType> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PVecDataType

@tqchen tqchen merged commit b2d80ce into apache:main Sep 19, 2021
@tqchen
Copy link
Member

tqchen commented Sep 19, 2021

Thanks @wrongtest ! This PR is now merged

AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Sep 20, 2021
@AndrewZhaoLuo
Merge branch 'main' into aluo/onnx/unsqueeze-alt
3f5e26d 
* main:
  [3/10] Moved TIR generation from Python to C++ for CMSIS-NN (apache#8951)
  Support match pvar with dtype constraint (apache#9016)
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@wrongtest-intellif @ylc
Support match pvar with dtype constraint (apache#9016)
a366b02
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@wrongtest-intellif @ylc
Support match pvar with dtype constraint (apache#9016)
dcaf8c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

@areusch areusch Awaiting requested review from areusch

@comaniac comaniac Awaiting requested review from comaniac

@jroesch jroesch Awaiting requested review from jroesch

@junrushao junrushao Awaiting requested review from junrushao

@merrymercy merrymercy Awaiting requested review from merrymercy

@vinx13 vinx13 Awaiting requested review from vinx13

@yzhliu yzhliu Awaiting requested review from yzhliu

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wrongtest-intellif @junrushao @tqchen