Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetaSchedule][M3b] Builder #9044

Merged
merged 3 commits into from
Sep 20, 2021
Merged

[MetaSchedule][M3b] Builder #9044

merged 3 commits into from
Sep 20, 2021

Conversation

junrushao
Copy link
Member

@junrushao junrushao commented Sep 18, 2021

This PR is part of the stage M3b of the meta schedule project (#8473).

The architecture is re-designed by Junru and Xiyou, and was first drafted by Junru, Wuwei, Ruihang, Bohan, Siyuan, Hongyi.

This Builder API in this PR allows any developers to implement Builder in either pure C++ (by inheriting meta_schedule::Builder) or pure python (by inheriting PyBuilder).

Review request: @jcf94 @comaniac @icemelon @zhiics @mbrookhart.

Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>

This PR is part of the meta schedule project (#8473)

Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some nits.
Will merge on Monday afternoon if no other objections.
Also it would be better to add at least one sentence to the PR description about what this PR does.

python/tvm/meta_schedule/builder/local_builder.py Outdated Show resolved Hide resolved
python/tvm/meta_schedule/builder/local_builder.py Outdated Show resolved Hide resolved
python/tvm/meta_schedule/builder/local_builder.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Clean, LGTM! One very minor nit. 😁

@@ -1204,7 +1204,7 @@ def FakeQuantizationToInteger():
x w
| |
dq dq
\ /
\\ /
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Why is your code formatter screwing with my ASCII Art? 😁

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha yeah it is intentional. Otherwise the unhappy pytest reports a warning demanding escape characters

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I wonder why I didn't see that in CI when I added this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here when I run the pytest, got a warning for this.

@comaniac comaniac merged commit 44d3934 into apache:main Sep 20, 2021
@comaniac
Copy link
Contributor

Thanks @junrushao1994 @mbrookhart

AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Sep 21, 2021
* main:
  Add back missing __init__.py to unbreak CI. (apache#9052)
  [Meta Schedule][M3b] Builder (apache#9044)
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* [Meta Schedule][M3b] Builder

This PR is part of the meta schedule project (apache#8473)

Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>

* add typing

* unreachable

Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* [Meta Schedule][M3b] Builder

This PR is part of the meta schedule project (apache#8473)

Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>

* add typing

* unreachable

Co-authored-by: Xiyou Zhou <xiyou@octoml.ai>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
@junrushao junrushao changed the title [Meta Schedule][M3b] Builder [MetaSchedule][M3b] Builder Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants