Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flake8 to docker/lint.sh #9055

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Add flake8 to docker/lint.sh #9055

merged 1 commit into from
Sep 22, 2021

Conversation

areusch
Copy link
Contributor

@areusch areusch commented Sep 20, 2021

Mousius added a commit to Mousius/tvm that referenced this pull request Sep 21, 2021
@Mousius
Migrate flake8 from workflow to lint script
cc245e0 
Saw apache#9055 adds `flake8.sh` to the `docker/lint.sh` and remembered I started doing this in apache#8652, but never updated it after the Docker images were actually updated.
@Mousius Mousius mentioned this pull request Sep 21, 2021
Merged
@Mousius
Copy link
Member

Mousius commented Sep 21, 2021

Hi @areusch,

Sorry for not finishing this properly, I actually never uncommented the flake8 line in tests/lint/flake8.sh 🙀 I've raised #9062 to do the final chunk of that migration.

Mousius added a commit to Mousius/tvm that referenced this pull request Sep 21, 2021
@Mousius
Migrate flake8 from workflow to lint script
ba3e5ee 
Saw apache#9055 adds `flake8.sh` to the `docker/lint.sh` and remembered I started doing this in apache#8652, but never updated it after the Docker images were actually updated.
areusch pushed a commit that referenced this pull request Sep 22, 2021
@Mousius
Migrate flake8 from workflow to lint script (#9062)
9258b96 
Saw #9055 adds `flake8.sh` to the `docker/lint.sh` and remembered I started doing this in #8652, but never updated it after the Docker images were actually updated.
Mousius
Mousius approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leandron leandron merged commit d9aae9c into apache:main Sep 22, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@Mousius @ylc
Migrate flake8 from workflow to lint script (apache#9062)
cc15794 
Saw apache#9055 adds `flake8.sh` to the `docker/lint.sh` and remembered I started doing this in apache#8652, but never updated it after the Docker images were actually updated.
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@areusch @ylc
Add flake8 to docker/lint.sh (apache#9055)
ab11680
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@Mousius @ylc
Migrate flake8 from workflow to lint script (apache#9062)
a9ccce0 
Saw apache#9055 adds `flake8.sh` to the `docker/lint.sh` and remembered I started doing this in apache#8652, but never updated it after the Docker images were actually updated.
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@areusch @ylc
Add flake8 to docker/lint.sh (apache#9055)
a809a4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jroesch jroesch jroesch approved these changes

@Mousius Mousius Mousius approved these changes

@junrushao junrushao junrushao approved these changes

@leandron leandron Awaiting requested review from leandron

Assignees

@jroesch jroesch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@areusch @Mousius @jroesch @junrushao @leandron