[Support] Add parallel_for_dynamic with dynamic schedules
#9056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
requested review from
areusch,
comaniac,
jroesch,
merrymercy,
tqchen,
yzhliu and
zhiics
as code owners
junrushao
changed the title
parallel_for_dynamic with dynamic schedules
YuchenJin
reviewed
Sep 21, 2021
YuchenJin
reviewed
Sep 21, 2021
| try { | ||
| worker(0); | ||
| } catch (const std::exception& e) { | ||
| for (auto&& thread : threads) { |
There was a problem hiding this comment.
Might be a C++ noob question: may I ask why using the auto&& r-value reference for thread?
There was a problem hiding this comment.
Actually I don't think there is much difference here :-) https://stackoverflow.com/questions/13130708/what-is-the-advantage-of-using-forwarding-references-in-range-based-for-loops
There was a problem hiding this comment.
Cool, thanks for the pointer! :)
YuchenJin
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
LGTM! Thanks @junrushao1994 for adding dynamic scheduling support!
zxybazh
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an API
parallel_for_dynamicwhich is analogous to OpenMP's dynamic scheduling below:CC: @jcf94 @zxybazh @comaniac