New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure AOT passes all intermediary storages to function calls #9064
Conversation
The actual fix good to me! Thank you. One aspect I would like to mention before this is getting merged: This currently replaces the original |
This iterates over the return storage IDs rather than just using the first one to ensure all of them get passed to subsequent calls. Fixes apache#9036
b95fdb2
to
fcb0bee
Compare
@PhilippvK, argh! The test said it was a simple BYOC case, I didn't realise it was exercising multiple sub graphs! I've re-added it for now, I think there's probably better test cases but fixing the bug takes priority - are you ok with just re-adding it? |
@Mousius oops I just realized, that I am in fact only generating a single subgraph, but a multi-output one. I will then just follow up with another test case and an improved |
@PhilippvK @Mousius so i'm not sure i'm seeing where we've added a multiple-return-value test case here. could you clarify for me? sorry to be dense :). |
@areusch The test case I came up with to reproduce to bug is quite messy because it does use manually written |
@PhilippvK i would like to make sure we are exercising the code change here in test, though. it's not clear to me we are...could you clarify? |
@areusch I ensured the test failed before I made it pass 😸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok got it now, makes sense!
…#9064) * Ensure AOT passes all intermediary storages to function calls This iterates over the return storage IDs rather than just using the first one to ensure all of them get passed to subsequent calls. Fixes apache#9036 * Re-introduce multi sub graph AOT test
…#9064) * Ensure AOT passes all intermediary storages to function calls This iterates over the return storage IDs rather than just using the first one to ensure all of them get passed to subsequent calls. Fixes apache#9036 * Re-introduce multi sub graph AOT test
This iterates over the return storage IDs rather than just using the
first one to ensure all of them get passed to subsequent calls.
Fixes #9036