[microTVM] Add wrapper for creating project using a MLF #9090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gromero
requested review from
areusch,
liangfu,
manupak and
tmoreau89
as code owners
Mousius
requested changes
Sep 23, 2021
python/tvm/micro/project.py
Outdated
| def generate_project_from_mlf( | ||
| template_project_dir: typing.Union[pathlib.Path, str], | ||
| project_dir: typing.Union[pathlib.Path, str], | ||
| mlf: typing.Union[pathlib.Path, str], |
There was a problem hiding this comment.
Suggested change
| mlf: typing.Union[pathlib.Path, str], | |
| mlf_path: typing.Union[pathlib.Path, str], |
python/tvm/micro/project.py
Outdated
| project_dir : pathlib.Path or str | ||
| Path to a directory where the project will be created. | ||
|
|
||
| mlf : pathlib.Path or str |
There was a problem hiding this comment.
Suggested change
| mlf : pathlib.Path or str | |
| mlf_path : pathlib.Path or str |
python/tvm/micro/project.py
Outdated
| mlf: typing.Union[pathlib.Path, str], | ||
| options: dict, | ||
| ): | ||
| """Generate a project from a platform template and an existing MLF. |
There was a problem hiding this comment.
Suggested change
| """Generate a project from a platform template and an existing MLF. | |
| """Generate a project from a platform template and an existing Model Library Format (MLF) archive. |
gromero
force-pushed
the
add-mlf-wrapper-function
branch
from
2f06922
to
7bdd26c
Compare
areusch
approved these changes
Sep 24, 2021
|
@gromero thanks, please fix the CI issue |
Mousius
approved these changes
Sep 24, 2021
Currently there is already a wrapper function for creating a new project directory based on an ExportableModule, but there isn't one for creating a new project directory based on an existing MLF archive, which is also handy. Hence that commit adds a new wrapper for creating a project using an existing model compiled and kept in a MLF archive. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org> Reviewed-by: Christopher Sidebottom <chris.sidebottom@arm.com> Reviewed-by: Andrew Reusch <areusch@octoml.ai>
gromero
force-pushed
the
add-mlf-wrapper-function
branch
from
7bdd26c
to
7f6da2c
Compare
|
@areusch @Mousius Thanks for the reviews. Sorry for the respin delay. I've fixed the offending line to satisfy the linter and also fixed the type hints for the added function (s/typing.Union/Union/) I think CI haven't caught it because the code is not being used currently -- I found that when using the code on my tvmc micro work. Hopefully 7f6da2c will be all right for the CI. Cheers. |
|
@leandron thanks! |
AndrewZhaoLuo
added a commit
to AndrewZhaoLuo/tvm
that referenced
this pull request
Sep 30, 2021
* main: (80 commits) Introduce centralised name transformation functions (apache#9088) [OpenCL] Add vectorization to cuda conv2d_nhwc schedule (apache#8636) [6/6] Arm(R) Ethos(TM)-U NPU codegen integration with `tvmc` (apache#8854) [microTVM] Add wrapper for creating project using a MLF (apache#9090) Fix typo (apache#9156) [Hotfix][Testing] Wait for RPCServer to be established (apache#9150) Update find cublas so it search default path if needed. (apache#9149) [TIR][LowerMatchBuffer] Fix lowering strides when source region has higher dimension than the buffer (apache#9145) Fix flaky NMS test by making sure scores are unique (apache#9140) [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc (apache#9038) [LLVM] Make changes needed for opaque pointers (apache#9138) Arm(R) Ethos(TM)-U NPU codegen integration (apache#8849) [CI] Split Integration tests out of first phase of pipeline (apache#9128) [Meta Schedule][M3b] Runner (apache#9111) Fix Google Mock differences between Ubuntu 18.04 and 16.04 (apache#9141) [TIR] add loop partition hint pragma (apache#9121) fix things (apache#9146) [Meta Schedule][M3a] SearchStrategy (apache#9132) [Frontend][PyTorch] support for quantized conv_transpose2d op (apache#9133) [UnitTest] Parametrized test_conv2d_int8_intrinsics (apache#9143) ...
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
Currently there is already a wrapper function for creating a new project directory based on an ExportableModule, but there isn't one for creating a new project directory based on an existing MLF archive, which is also handy. Hence that commit adds a new wrapper for creating a project using an existing model compiled and kept in a MLF archive. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org> Reviewed-by: Christopher Sidebottom <chris.sidebottom@arm.com> Reviewed-by: Andrew Reusch <areusch@octoml.ai>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Currently there is already a wrapper function for creating a new project directory based on an ExportableModule, but there isn't one for creating a new project directory based on an existing MLF archive, which is also handy. Hence that commit adds a new wrapper for creating a project using an existing model compiled and kept in a MLF archive. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org> Reviewed-by: Christopher Sidebottom <chris.sidebottom@arm.com> Reviewed-by: Andrew Reusch <areusch@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is already a wrapper function for creating a new project
directory based on an ExportableModule, but there isn't one for creating
a new project directory based on an existing MLF archive, which is also
handy. Hence that commit adds a new wrapper for creating a project using
an existing model compiled and kept in a MLF archive.
Signed-off-by: Gustavo Romero gustavo.romero@linaro.org