[BugFix][Meta Schedule] Fix meta_schedule.testing.local_rpc #9172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
requested review from
comaniac,
jroesch,
tqchen,
yzhliu and
zhiics
as code owners
tqchen
approved these changes
Oct 1, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the suggestion from @tqchen, this PR disallows automatic worker discovery in RPCRunner, in order to accommodate the case where several tuning processes may share the same RPCTracker in the real world. In this case, automatic discovery is problematic because it could only find the workers that are idle. This addresses the flakiness in meta schedule unittests by the way because now the runner assumes
max_workers=1