[TVMC] Treat invalid FILE arguments #9213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if an invalid FILE argument is passed to 'tvmc run' the user will catch a traceback because exceptions are not treated, for instance: $ tvmc run /tmp/nonexistingfile will throw a FileNotFoundError trace. This commit catches the possible exceptions that can happen when an invalid FILE argument is used and convert them to better messages for the user so the invalid FILE can be easily spotted. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
|
@leandron Just crossed it when wrapping up things for |
masahi
pushed a commit
to Laurawly/tvm-1
that referenced
this pull request
Oct 14, 2021
Currently if an invalid FILE argument is passed to 'tvmc run' the user will catch a traceback because exceptions are not treated, for instance: $ tvmc run /tmp/nonexistingfile will throw a FileNotFoundError trace. This commit catches the possible exceptions that can happen when an invalid FILE argument is used and convert them to better messages for the user so the invalid FILE can be easily spotted. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
Currently if an invalid FILE argument is passed to 'tvmc run' the user will catch a traceback because exceptions are not treated, for instance: $ tvmc run /tmp/nonexistingfile will throw a FileNotFoundError trace. This commit catches the possible exceptions that can happen when an invalid FILE argument is used and convert them to better messages for the user so the invalid FILE can be easily spotted. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Currently if an invalid FILE argument is passed to 'tvmc run' the user will catch a traceback because exceptions are not treated, for instance: $ tvmc run /tmp/nonexistingfile will throw a FileNotFoundError trace. This commit catches the possible exceptions that can happen when an invalid FILE argument is used and convert them to better messages for the user so the invalid FILE can be easily spotted. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if an invalid FILE argument is passed to 'tvmc run' the user
will catch a traceback because exceptions are not treated, for instance:
$ tvmc run /tmp/nonexistingfile will throw a FileNotFoundError trace.
This commit catches the possible exceptions that can happen when an
invalid FILE argument is used and convert them to better messages for
the user so the invalid FILE can be easily spotted.
Signed-off-by: Gustavo Romero gustavo.romero@linaro.org