[LLVM] Treat scalars as single-lane vectors in CreateVecConcat #9264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM differentiates between `<1 x ty>` and `ty`, while TVM does not. Make sure that a bunch of TVM scalars can be concatenated into a vector when generating LLVM IR.
kparzysz-quic
requested review from
areusch,
comaniac,
jroesch,
junrushao,
masahi,
merrymercy,
tqchen,
vinx13,
yzhliu and
ZihengJiang
as code owners
AndrewZhaoLuo
approved these changes
Oct 12, 2021
masahi
approved these changes
Oct 13, 2021
masahi
pushed a commit
to Laurawly/tvm-1
that referenced
this pull request
Oct 14, 2021
…e#9264) LLVM differentiates between `<1 x ty>` and `ty`, while TVM does not. Make sure that a bunch of TVM scalars can be concatenated into a vector when generating LLVM IR.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…e#9264) LLVM differentiates between `<1 x ty>` and `ty`, while TVM does not. Make sure that a bunch of TVM scalars can be concatenated into a vector when generating LLVM IR.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…e#9264) LLVM differentiates between `<1 x ty>` and `ty`, while TVM does not. Make sure that a bunch of TVM scalars can be concatenated into a vector when generating LLVM IR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM differentiates between
<1 x ty>andty, while TVM does not. Make sure that a bunch of TVM scalars can be concatenated into a vector when generating LLVM IR.