Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Call with TIRCallAttrs to call_lowered op #9312

Merged
merged 5 commits into from
Nov 10, 2021
Merged

Change Call with TIRCallAttrs to call_lowered op #9312

merged 5 commits into from
Nov 10, 2021

Commits on Nov 10, 2021

  1. Introduce call_lowered op 

    Add op vm.call_tir

Change from checking if CallNode has CallTIRAttrs to checking if the Op is vm.call_tir

Change device_domains to use vm.call_tir op more explicitly

Fixed issue in type checker, now have seg fault :(

Fix typo -- most of VM tests pass now

Interpreter now deals with call_tir properly

Fix typo in te_compiler

Use InvokeTVMOp and CallTIR

Add some checks to graph_plan_memory.cc

Make GetToken skip function types

C++ TESTS PASS WOOHOO

Remove prints

formatting

vm.call_tir -> call_tir and more comment removals

call_tir -> call_lowered

fix lint

clang format

Remove compute from non computational vm ops

missed some semicolons in prev commit

Fix warning

Move call_lowered to relay/op/call/call.cc and rename util func

Add helper fn that returns lowered_call op

fix import order

clang format

Add constraint to call_lowered type rel

clean up empty token vector

comment

Move CallTIRAttrs to include/tvm/relay/attrs/call.h

Rename TIRCallAttrs as CallLoweredAttrs

lint

Add helper for extracting func and args from call_lowered

Change graph_executor_codegen to use helper function

Update interpreter to use helper

Fix device_domains.cc -- could still use cleanup, also I am not sure why there are still direct calls to primfns in DomainforCallee

Clean up DeviceCopyProps and lint

lint

return CallLoweredAttrs with the extern func

comment

note in comment

Progress & notes. Realized that I am not handling externs correctly

not sure why this ever worked before?

Clean up CreateFuncCall signature, notes

comments

Fix extern function handling

extern_function -> extern_func

fix DeviceAwareVisitExpr_ -- now it handles both lowered and normal calls

yay passes AOT tests!

formatting and comment removal

cleanup

Introduce call_lowered op
    @electriclilies
    electriclilies committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    5e79ba5 View commit details
    Browse the repository at this point in the history

  2. lint

    @electriclilies
    electriclilies committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    8960dcd View commit details
    Browse the repository at this point in the history

  3. Fix AOT to deal with externs

    @electriclilies
    electriclilies committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    e0e50fa View commit details
    Browse the repository at this point in the history

  4. add const auto&

    @electriclilies
    electriclilies committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    2dd601b View commit details
    Browse the repository at this point in the history

  5. Fix aot crt test

    @electriclilies
    electriclilies committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    207c487 View commit details
    Browse the repository at this point in the history