[PyTest] Sort by test location, but not parametrization #9353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A follow-up from apache#9188. The `item.location` tuple contains `(filename, line_number, test_name)`, where the `test_name` includes a string representation of all parameters. This change preserves pytest's sorting of parametrized values within a parametrized test, rather than sorting by strings.
Lunderberg
requested review from
comaniac,
jroesch,
junrushao,
tqchen,
yzhliu and
zhiics
as code owners
jroesch
approved these changes
Oct 26, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
A follow-up from apache#9188. The `item.location` tuple contains `(filename, line_number, test_name)`, where the `test_name` includes a string representation of all parameters. This change preserves pytest's sorting of parametrized values within a parametrized test, rather than sorting by strings.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
A follow-up from apache#9188. The `item.location` tuple contains `(filename, line_number, test_name)`, where the `test_name` includes a string representation of all parameters. This change preserves pytest's sorting of parametrized values within a parametrized test, rather than sorting by strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up from #9188. The
item.locationtuple contains(filename, line_number, test_name), where thetest_nameincludes a string representation of all parameters. This change preserves pytest's sorting of parametrized values within a parametrized test, rather than sorting by strings.