[HOTFIX][TARGET] Change LOG in compilation config to DLOG #9486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompilationConfig was merged in on the basis that it is an internal experimental structure that helps to group the target. Constructing the config should not emit messages for most cases. Change LOG(INFO) to DLOG(INFO) so users won't be overwhelmed by messages. There are a few warning cases that also changes to DLOG. Given CompilationConfig is still experimental, it would be better to respect the current default convention and not trigger warnings that indicate an non-experimental suggestion. Warnings can be updated according with the convention.
tqchen
requested review from
junrushao,
kparzysz-quic,
masahi,
vinx13 and
ZihengJiang
as code owners
|
Fixes #9487 cc @mbs-octoml @zxybazh @Lunderberg @csullivan @masahi |
|
cc @junrushao1994 this needs to go into v0.8 release |
|
sorry for the trouble -- i'll assume log messages are part of the api and not get so trigger happy. |
csullivan
approved these changes
Nov 10, 2021
Lunderberg
approved these changes
Nov 10, 2021
|
Retriggered the CI upon failure |
junrushao
approved these changes
Nov 10, 2021
|
cc @Mousius a weird CI error from Can you take a look at what's going on? Looks like #9480 didn't fix the problem? |
|
i just re-re-triggered the CI and let's see how it goes. |
|
The CI doesn't fail this time. Thanks for the quick fix! |
AndrewZhaoLuo
added a commit
to AndrewZhaoLuo/tvm
that referenced
this pull request
Nov 12, 2021
* main: (119 commits) [Topi][Op][PyTorch][Vitas] Fix inconsistent kernel layout conventions for conv2d_transpose (apache#9336) Fix repository URL in ubuntu_install_rocm.sh (apache#9425) Add LLVM-13 installation to Docker setup (apache#9498) [Relay] Use target_host determined at Relay level instead of recalculating it (apache#9499) Arm(R) Ethos(TM)-U NPU BinaryElementwise operators support (apache#9442) [COMMUNITY] Junru's and Wuwei's PGP key for ASF release (apache#9488) Add default for split op (apache#9489) [HOTFIX][TARGET] Change LOG in compilation config to DLOG (apache#9486) Fixed some warnings about lambda's closures that are bigger than necessary (apache#9481) [Support] Add libinfo into the runtime build (apache#9310) Change Call with TIRCallAttrs to call_lowered op (apache#9312) [ETHOSN] Streamline Ethos(TM)-N cross-compile rpc usage (apache#9477) [CMSIS-NN] Assert correct amount of CMSIS-NN artifacts in MLF (apache#9480) [MicroTVM][PyTest] Explicitly skip MicroTVM unittests. (apache#9335) [microNPU] Replace ICHECK with diagnostic context in type inference (apache#9470) Better host handling in CompilationConfig & debug printing (apache#9460) [AOT][Tests] Use pre-built libraries in Reference System tests (apache#9271) [TIR] Add type hint for TIR (apache#9432) [TVMC] Add test for quantized pytorch model (apache#9467) [CMSIS-NN] Convert CMSIS-NN to use Target Hooks (apache#9397) ...
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
CompilationConfig was merged in on the basis that it is an internal experimental structure that helps to group the target. Constructing the config should not emit messages for most cases. Change LOG(INFO) to DLOG(INFO) so users won't be overwhelmed by messages. There are a few warning cases that also changes to DLOG. Given CompilationConfig is still experimental, it would be better to respect the current default convention and not trigger warnings that indicate an non-experimental suggestion. Warnings can be updated according with the convention.
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
CompilationConfig was merged in on the basis that it is an internal experimental structure that helps to group the target. Constructing the config should not emit messages for most cases. Change LOG(INFO) to DLOG(INFO) so users won't be overwhelmed by messages. There are a few warning cases that also changes to DLOG. Given CompilationConfig is still experimental, it would be better to respect the current default convention and not trigger warnings that indicate an non-experimental suggestion. Warnings can be updated according with the convention.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
CompilationConfig was merged in on the basis that it is an internal experimental structure that helps to group the target. Constructing the config should not emit messages for most cases. Change LOG(INFO) to DLOG(INFO) so users won't be overwhelmed by messages. There are a few warning cases that also changes to DLOG. Given CompilationConfig is still experimental, it would be better to respect the current default convention and not trigger warnings that indicate an non-experimental suggestion. Warnings can be updated according with the convention.
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
CompilationConfig was merged in on the basis that it is an internal experimental structure that helps to group the target. Constructing the config should not emit messages for most cases. Change LOG(INFO) to DLOG(INFO) so users won't be overwhelmed by messages. There are a few warning cases that also changes to DLOG. Given CompilationConfig is still experimental, it would be better to respect the current default convention and not trigger warnings that indicate an non-experimental suggestion. Warnings can be updated according with the convention.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
CompilationConfig was merged in on the basis that it is an internal experimental structure that helps to group the target. Constructing the config should not emit messages for most cases. Change LOG(INFO) to DLOG(INFO) so users won't be overwhelmed by messages. There are a few warning cases that also changes to DLOG. Given CompilationConfig is still experimental, it would be better to respect the current default convention and not trigger warnings that indicate an non-experimental suggestion. Warnings can be updated according with the convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompilationConfig was merged in on the basis that it is an internal experimental
structure that helps to group the target. Constructing the config should not
emit messages for most cases. Change LOG(INFO) to DLOG(INFO)
so users won't be overwhelmed by messages.
There are a few warning cases that also changes to DLOG. Given CompilationConfig
is still experimental, it would be better to respect the current default convention
and not trigger warnings that indicate an non-experimental suggestion.
Warnings can be updated according to the convention as it evolves.