Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microNPU] Support binary elementwise with non-4D inputs #9521

Merged
merged 3 commits into from
Nov 25, 2021

Conversation

lhutton1
Copy link
Contributor

@lhutton1 lhutton1 commented Nov 17, 2021

Reshapes non-4D inputs to become 4D, then reshapes the output back to the non-4D input shape after selected binary elementwise operation is performed.

cc @ekalda @NicolaLancellotti @manupa-arm @dchauhan-arm

Copy link
Contributor

@ekalda ekalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should codegen test few more special cases, but otherwise looks really good! :)

python/tvm/relay/op/contrib/ethosu.py Show resolved Hide resolved
Copy link
Contributor Author

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @ekalda!

python/tvm/relay/op/contrib/ethosu.py Show resolved Hide resolved
Reshapes non-4D inputs to become 4D, then reshapes the output back to
the non-4D input shape.

Change-Id: I680ac06841aa1323435bcd09b6996fc57117cd84
Change-Id: I5bae1bd11fa0c82e3ffd882fddfcb925dff259cb
Change-Id: I6167cf73b2722902212717c5243cd19edc3489b7
Copy link
Contributor

@NicolaLancellotti NicolaLancellotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @lhutton1.

Copy link
Contributor

@ekalda ekalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :) Thanks @lhutton1

Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manupak manupak merged commit 0a4cc89 into apache:main Nov 25, 2021
@manupak
Copy link
Contributor

manupak commented Nov 25, 2021

Thanks! @lhutton1 @NicolaLancellotti @ekalda

@lhutton1 lhutton1 deleted the binary-elementwise-non-4d branch November 25, 2021 14:40
dchauhan-arm pushed a commit to dchauhan-arm/tvm that referenced this pull request Nov 29, 2021
Reshapes non-4D inputs to become 4D, then reshapes the output back to
the non-4D input shape.
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
Reshapes non-4D inputs to become 4D, then reshapes the output back to
the non-4D input shape.
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
Reshapes non-4D inputs to become 4D, then reshapes the output back to
the non-4D input shape.
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
Reshapes non-4D inputs to become 4D, then reshapes the output back to
the non-4D input shape.
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
Reshapes non-4D inputs to become 4D, then reshapes the output back to
the non-4D input shape.
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 12, 2022
Reshapes non-4D inputs to become 4D, then reshapes the output back to
the non-4D input shape.
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
Reshapes non-4D inputs to become 4D, then reshapes the output back to
the non-4D input shape.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants