-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bot to ping reviewers after no activity #9973
Conversation
4ae72f0
to
ddf0a4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! this is a great feature add.
ddf0a4b
to
272d361
Compare
3399bc4
to
627bac3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @driazati, can you also add some docs in https://tvm.apache.org/docs/contribute/code_review.html?
627bac3
to
da38773
Compare
da38773
to
fb5f2dd
Compare
fb5f2dd
to
ca8f8b1
Compare
ca8f8b1
to
1d92aef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving so we can try this out. it's scoped to just folks who are cc'd in the attached issue. before we broaden the list of people who will get pinged, we'll raise an RFC to discuss this process change.
* Add bot to ping reviewers after no activity * Address comments Co-authored-by: driazati <driazati@users.noreply.github.com>
This will add a comment from GitHub actions after X amount of time has passed after the last comment on a PR. This should help keep the backlog of PRs clean by remininding people to do a review or update their PRs. Unlike issues where having long term open issues that are legit bugs, PRs shouldn't be open indefinitely, so this bot will incentivize people to keep the PR backlog clean.
The specific rule this operates under is: if there has been no comment or review in
--wait-time-minutes
(as checked by GitHub Actions every 15 minutes via the cron workflow in this PR), leave a comment on the PR @-ing all the relevant people, including anyone who has left a review or who was cc'ed at any point in the PR.This is going to start out as opt-in only (with the goal of rolling it out to everyone after like a week or so) just because it's pretty difficult to test. To opt-in, add yourself as a cc'ed user on #9983
cc @areusch @jroesch @denise-k