Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QNN] Add qnn.rsqrt op #9982

Merged
merged 2 commits into from Jan 24, 2022
Merged

[QNN] Add qnn.rsqrt op #9982

merged 2 commits into from Jan 24, 2022

Conversation

sfvaroglu
Copy link
Contributor

Add QNN op for reciprocal sqrt, the default legalization goes through dequantize->rsqrt->quantize

Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a more concrete comment on the design decision for canonicalizing to fp32 and possible future workarounds, but otherwise, a quick overview looks great!

src/relay/qnn/op/rsqrt.cc Show resolved Hide resolved
@AndrewZhaoLuo AndrewZhaoLuo changed the title Add qnn.rsqrt op [QNN] Add qnn.rsqrt op Jan 19, 2022
Copy link
Contributor

@AndrewZhaoLuo AndrewZhaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , but one comment

@AndrewZhaoLuo
Copy link
Contributor

Probably just need to rebase on main after 589fc01

The CI failure does not seem to be the fault of the PR

@AndrewZhaoLuo AndrewZhaoLuo merged commit 6f2b35f into apache:main Jan 24, 2022
yuanfz98 pushed a commit to yuanfz98/tvm that referenced this pull request Jan 24, 2022
* Add qnn.rsqrt op

* Add comment
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
* Add qnn.rsqrt op

* Add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants