Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIMA-6460] Move tycho and auto-staging to parent pom #20

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented May 19, 2022

JIRA Ticket: https://issues.apache.org/jira/browse/UIMA-6460

What's in the PR

  • Minimum Maven 3.2.2 because then it starts to AND profile conditions together
  • Minimum Java version for building is 11 because Tycho is using class file major version 55
  • Enable autoVersionSubmodules by default during release
  • Remove note that using 'marker-file-identifying-parent-pom' to generate a Jira report is broken because it actually seems to work
  • Add "clean" configuration to remove Jira report when doing a "mvn clean"
  • Remove "mavenJirareportSkip" - I doubt it is used and there are better ways to skip the report
  • Added tycho and tycho-module profiles
  • Added release-rc-auto-staging profiles
  • Removed redundant empty "checksum-maven-plugin" section

How to test manually

  • Run downstream build and check all works ok (you may have to slightly adapt the downstream Maven config though)

Automatic testing

  • PR adds/updates unit tests

Documentation

  • PR adds/updates documentation

Organizational

  • PR includes new dependencies.
    Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.

- Minimum Maven 3.2.2 because then it starts to AND profile conditions together
- Minimum Java version for building is 11 because Tycho is using class file major version 55
- Enable autoVersionSubmodules by default during release
- Remove note that using 'marker-file-identifying-parent-pom' to generate a Jira report is broken because it actually seems to work
- Add "clean" configuration to remove Jira report when doing a "mvn clean"
- Remove "mavenJirareportSkip" - I doubt it is used and there are better ways to skip the report
- Added tycho and tycho-module profiles
- Added release-rc-auto-staging profiles
- Removed redundant empty "checksum-maven-plugin" section
@reckart reckart added the ⚙️ Refactoring Improvement for development or maintainability label May 19, 2022
@reckart reckart added this to the 15 milestone May 19, 2022
@reckart reckart self-assigned this May 19, 2022
@reckart reckart merged commit 5fc7c20 into main May 19, 2022
@reckart reckart deleted the refactoring/UIMA-6460-Move-tycho-and-auto-staging-to-parent-pom branch May 19, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Refactoring Improvement for development or maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant