Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CAS serialization tests more robust #292

Closed
reckart opened this issue Jan 23, 2023 · 0 comments
Closed

Make CAS serialization tests more robust #292

reckart opened this issue Jan 23, 2023 · 0 comments
Assignees
@reckart
Labels
⚙️ Refactoring Improvement for development or maintainability
Milestone
3.4.0

Comments

@reckart
Copy link
Member

reckart commented Jan 23, 2023

Describe the refactoring action
Use content comparison instead of binary file comparison for more CAS serialization tests.

Expected benefit
Avoid breaking when the binary representation slightly varies but the content is semantically the same.
@reckart reckart added the ⚙️ Refactoring Improvement for development or maintainability label Jan 23, 2023
@reckart reckart added this to the 3.4.0 milestone Jan 23, 2023
@reckart reckart self-assigned this Jan 23, 2023
reckart added a commit that referenced this issue Jan 23, 2023
@reckart
Issue #292: Make CAS serialization tests more robust
a955a0d 
- run SerRef tests using a content comparison
reckart added a commit that referenced this issue Jan 25, 2023
@reckart
Merge pull request #293 from apache/refactoring/292-Make-CAS-serializ…
7fc0662 
…ation-tests-more-robust

Issue #292: Make CAS serialization tests more robust
@reckart reckart closed this as completed Jan 25, 2023
reckart added a commit that referenced this issue Jan 25, 2023
@reckart
Merge branch 'main' into release/288-Apache-UIMA-3.4.0
cac4ddb 
* main:
  No issue: Protect main again (actually main-v2)
  No issue: Temporarily unprotect main so I can update the last commit metadata using a force push...
  Issue #292: Make CAS serialization tests more robust
  Issue #272: select on FSArray seems broken
  Issue #270: Update dependencies (3.4.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⚙️ Refactoring Improvement for development or maintainability
Projects
None yet
Milestone
3.4.0
Development

No branches or pull requests
1 participant
@reckart