UIMA-6367: JCas cover annotation created in PEAR context replaced during index operations #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pkluegl
commented
May 27, 2021
pkluegl
commented
- fixed trampoline map
- added test that checks annotation instance in mocked pear context
pkluegl
changed the title
|
It is great that we have the test and the fix, but the test name is not self-explanatory and the test has no JavaDoc. We should add a properly explanatory JavaDoc to this test, otherwise if it at some point breaks, it takes ages until somebody understands the scenario that is tested here. |
…ing index operations - fixed trampoline map - added test that checks annotation instance in mocked pear context
reckart
force-pushed
the
bugfix/UIMA-6367-JCas-cover-annotation-created-in-PEAR-context-replaced-during-index-operations
branch
from
ebe476b
to
e3f24b1
Compare
reckart
force-pushed
the
bugfix/UIMA-6367-JCas-cover-annotation-created-in-PEAR-context-replaced-during-index-operations
branch
from
e3f24b1
to
7b42ef4
Compare
…ing index operations - Improve test - Add a debug message if CAS switchClassLoader is called with a non UimaClassLoader because the UimaClassLoader has special magic without which the FS generators may create JCas wrappers from the wrong classloader (i.e. not the swiched classloader but the app classloader)
reckart
deleted the
bugfix/UIMA-6367-JCas-cover-annotation-created-in-PEAR-context-replaced-during-index-operations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.