Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#228 - Move the UimaDecompiler class #229

Merged
merged 4 commits into from
Jul 29, 2022

Conversation

reckart
Copy link
Member

@reckart reckart commented Jul 28, 2022

What's in the PR

  • Move the decompiler class
  • Remove dependencies of uimaj-core that were only required by the decompiler
  • Add these dependencies to uimaj-v3migration-jcas

How to test manually

  • No specific test procedure

Automatic testing

  • PR adds/updates unit tests

Documentation

  • PR adds/updates documentation

Organizational

  • PR includes new dependencies.
    Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.

@reckart reckart added the ⚙️ Refactoring Improvement for development or maintainability label Jul 28, 2022
@reckart reckart added this to the 3.4.0 milestone Jul 28, 2022
@reckart reckart self-assigned this Jul 28, 2022
@reckart reckart marked this pull request as ready for review July 28, 2022 10:18
@reckart reckart force-pushed the refactoring/228-Move-the-UimaDecompiler-class branch from 09e7d9e to 6a37c25 Compare July 28, 2022 10:19
- Move the decompiler class
- Remove dependencies of uimaj-core that were only required by the decompiler
- Add these dependencies to uimaj-v3migration-jcas
@reckart reckart force-pushed the refactoring/228-Move-the-UimaDecompiler-class branch from 6a37c25 to dd748b4 Compare July 28, 2022 11:10
@reckart reckart merged commit 2f6692a into main Jul 29, 2022
@reckart reckart deleted the refactoring/228-Move-the-UimaDecompiler-class branch July 29, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Refactoring Improvement for development or maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant