Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #226: Provide SPI interfaces to locate descriptors and JCas classes #249

Conversation

reckart
Copy link
Member

@reckart reckart commented Aug 29, 2022

What's in the PR

  • When obtaining a MH for a lookup through a custom classloader, make sure it is a UIMAClassLoader because otherwise the MHLC magic cannot work and the JCas classes get loaded through the wrong classloader - in particular applies to SPIs in an OSGI environment

How to test manually

  • No specific test procedure

Automatic testing

  • PR adds/updates unit tests

Documentation

  • PR adds/updates documentation

Organizational

  • PR adds/updates dependencies.
    Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.

…sses

- When obtaining a MH for a lookup through a custom classloader, make sure it is a UIMAClassLoader because otherwise the MHLC magic cannot work and the JCas classes get loaded through the wrong classloader - in particular applies to SPIs in an OSGI environment
@reckart reckart added the ⭐️ Enhancement Improvement or new feature for users label Aug 29, 2022
@reckart reckart added this to the 3.4.0 milestone Aug 29, 2022
@reckart reckart self-assigned this Aug 29, 2022
@reckart reckart merged commit 7deca1e into main Aug 31, 2022
@reckart reckart deleted the feature/226-Provide-SPI-interfaces-to-locate-descriptors-and-JCas-classes branch August 31, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐️ Enhancement Improvement or new feature for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant