Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #275: Improved error message made it even more misleading #276

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented Jan 11, 2023

What's in the PR

  • Added tests for the different error messages
  • Found out that the recently introduced error message makes no sense and removed it
  • Improved wording of a few additional error messages

How to test manually

  • No specific test procedure

Automatic testing

  • PR adds/updates unit tests

Documentation

  • PR adds/updates documentation

Organizational

  • PR adds/updates dependencies.
    Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.

- Added tests for the different error messages
- Found out that the recently introduced error message makes no sense and removed it
- Improved wording of a few additional error messages
@reckart reckart added the 🦟 Bug Something isn't working label Jan 11, 2023
@reckart reckart added this to the 3.4.0 milestone Jan 11, 2023
@reckart reckart self-assigned this Jan 11, 2023
…en-more-misleading

* main:
  No issue: Remove Jira line from PR template - we do not use Jira anymore.
  #270 - Update dependencies
@reckart reckart merged commit 4a033e3 into main Jan 11, 2023
@reckart reckart deleted the bugfix/275-Improved-error-message-made-it-even-more-misleading branch January 11, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦟 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant