Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#298 - SHA512 checksums contain wrong file name #299

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

reckart
Copy link
Member

@reckart reckart commented Jan 25, 2023

What's in the PR

  • Remove finalName override from the build section

How to test manually

  • Check that the checksum files now contain the proper filename
  • Run release build
  • Check if Eclipse plugins can still be installed
  • Check if examples are still there
  • Check that descriptors can still be opened using Eclipse plugins
  • Check that at least one of the launch configs shipped with UIMA still works

Automatic testing

  • PR adds/updates unit tests

Documentation

  • PR adds/updates documentation

Organizational

  • PR adds/updates dependencies.
    Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.

- Remove finalName override from the build section
@reckart reckart added the 🦟 Bug Something isn't working label Jan 25, 2023
@reckart reckart added this to the 3.4.0 milestone Jan 25, 2023
@reckart reckart self-assigned this Jan 25, 2023
@reckart reckart merged commit c575bf9 into main Jan 25, 2023
@reckart reckart deleted the bugfix/298-SHA512-checksums-contain-wrong-file-name branch January 25, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦟 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant