Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIMA-6225] Unable to install a pear package into a directory containing special character like <,> or & #39

Conversation

reckart
Copy link
Member

@reckart reckart commented May 4, 2020

  • Escape XML element values in XMLUtil (which is used to serialize PEAR installation descriptors
  • Added unit test trying to install PEAR into a path with an XML special character
  • Cleaned up and modernized TestPearInstallationVerification
  • Formatted XMLUtil (basically adding missing curlies)

JIRA: https://issues.apache.org/jira/browse/UIMA-6225

…ing special character like <,> or &

- Escape XML element values in XMLUtil (which is used to serialize PEAR installation descriptors
- Added unit test trying to install PEAR into a path with an XML special character
- Cleaned up and modernized TestPearInstallationVerification
@reckart reckart added the 🦟 Bug Something isn't working label May 4, 2020
@reckart reckart added this to the 2.10.5 milestone May 4, 2020
@reckart reckart requested a review from mischor May 4, 2020 12:44
@reckart reckart self-assigned this May 4, 2020
@reckart
Copy link
Member Author

reckart commented May 4, 2020

When reviewing, please switch the diff view to ignore whitespace to reduce visual clutter introduced by the formatting/curlies:

Screenshot 2020-05-04 at 14 45 05

@reckart reckart merged commit 2b30152 into master-v2 May 12, 2020
@reckart reckart deleted the UIMA-6225-PEAR-install-fails-with-XMl-special-chars-in-target-path branch May 12, 2020 09:23
@reckart reckart restored the UIMA-6225-PEAR-install-fails-with-XMl-special-chars-in-target-path branch May 12, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦟 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants