Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .travis.yml for testing the PRs at https://travis-ci.com/apache/velocity-engine #18

Merged
merged 1 commit into from Nov 25, 2020

Conversation

martin-g
Copy link
Member

Remove unused imports in OldPropertiesTestCase. It failed compiling on my local because I use JDK 15 by default.

@arkanovicz
Copy link
Contributor

From seeing the output, the failing test looks like a test isolation leak between ugly1.vtl and ugly2.vtl : ugly2 defines the #foo macro to render bar, ugly1 output should never display bar.

Looking at the code, I don't understand for now where it can come from, since in the SpaceGlobbing test case, each test is using its own engine, output filename and context. Behaviors should be totally hermetic, even ran in parallel, so for now it's a mystery to me.

@martin-g
Copy link
Member Author

I think I figured it out:
it seems on TravisCI File[] directoryListing = dir.listFiles(); returns first "ugly2.vtl" and then `ugly.vtl" and due to this the context for ugly1 is "dirty".
I've moved the initialization of VelocityEngine one level/method later and now everything is OK.

Please let me know if you want me to squash the commits!

@arkanovicz
Copy link
Contributor

Oh, well done. Hadn't thought of that.
Yes, squash, please.

@martin-g
Copy link
Member Author

Squashed and force-pushed!
TravisCI is happy!

@arkanovicz arkanovicz merged commit 15429af into apache:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants