Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VELOCITY-942 - VelocityViewServlet extending from jakarta.servlet instead of javax.servlet #15

Closed
wants to merge 1 commit into from

Conversation

ppodgorsek
Copy link

No description provided.

@michael-o
Copy link
Member

This can't be serious

@michael-o michael-o closed this Jul 12, 2023
@ChristopherSchultz
Copy link

I think it's totally serious. IMO, VelocityTools needs a branch (or main) to migrate to Jakarta EE. Not everybody is going to let their web applications languish forever. At $work we are planning our migrations and for the time being we are looking at relying on Tomcat's Migration Tool for projects like Velocity-Tools that don't appear to have any plans to produce compatible versions.

That's not a good long-term solution.

@ppodgorsek
Copy link
Author

@michael-o Can you explain why modernising Velocity to use Jakarta is a joke for you? It's not right to expect all downstream projects to use the Tomcat migration tool when this issue can be easily fixed centrally in Velocity.

If Velocity is never updated, should the community consider that it's part of the Apache attic? I'm more than happy to switch to Thymeleaf if that's the attitude we get when trying to contribute to make a project more usable.

Besides, it would be good to also keep the issue tracker up-to-date with explanations there too, that's the basics.

@michael-o
Copy link
Member

I can easily explain why I have immediate closed this out: Before opening a PR for such a high-impact change I would expect a discussion in the JIRA issue about a possible solution for everyone. You just dropping off this PR which solves your problem by changing the code in main leaving everyone else behind which do rely on javax namespace for the years to come. This is not acceptable. I totally understand that people including you want to make use of jakarta namespace, but this is not the right approach.
@ppodgorsek This is zero modernization Velocity, it is merely a namespace change, that's it.

Make a reasonable proposal and I will have a look at this.

@ppodgorsek ppodgorsek deleted the VELOCITY-942 branch July 12, 2023 23:00
@ghueller
Copy link

ghueller commented Jan 9, 2024

I can't believe that this has been turned down. this is not the problem of one committer but of everyone who wants to keep his software up-to-date. Currently, velocity-tools is preventing this (and as this commit shows, intentionally).

@michael-o
Copy link
Member

I can't believe that this has been turned down. this is not the problem of one committer but of everyone who wants to keep his software up-to-date. Currently, velocity-tools is preventing this (and as this commit shows, intentionally).

I hope you have read my explanation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants