Upgrade to Atmosphere 2.4.2

[payou]

No description provided.

[martin-g]

Why this is needed?

[payou]

Don't remember why.
I commit again

[martin-g]

2.4.3 has been released in the meantime.

[martin-g]

Ah, I didn't notice that you have updated the PR.
I'll test it locally and update to 2.4.3 if everything is OK.
Thank you!

[martin-g]

There are some problems with the PR.
Initially its single unit test was failing.
I've fixed it by using again TesterBroadcaster.

Now deployment at Tomcat 8.x fails with:

java.lang.NullPointerException
    org.atmosphere.handler.ReflectorServletProcessor.loadServlet(ReflectorServletProcessor.java:104)
    org.atmosphere.handler.ReflectorServletProcessor.loadWebApplication(ReflectorServletProcessor.java:84)
    org.atmosphere.handler.ReflectorServletProcessor.init(ReflectorServletProcessor.java:172)
    org.atmosphere.cpr.AtmosphereFramework.initAtmosphereHandler(AtmosphereFramework.java:1732)
    org.atmosphere.cpr.AtmosphereFramework.initAtmosphereHandler(AtmosphereFramework.java:1721)
    org.atmosphere.cpr.AtmosphereFramework.init(AtmosphereFramework.java:917)
    org.atmosphere.cpr.AtmosphereFramework.init(AtmosphereFramework.java:838)
    org.atmosphere.cpr.AtmosphereFrameworkInitializer.configureFramework(AtmosphereFrameworkInitializer.java:75)
    org.atmosphere.cpr.AtmosphereServlet.configureFramework(AtmosphereServlet.java:84)
    org.atmosphere.cpr.AtmosphereServlet.configureFramework(AtmosphereServlet.java:80)
    org.atmosphere.cpr.AtmosphereServlet.init(AtmosphereServlet.java:75)
    org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:501)
    org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79)
    org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:610)
    org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:516)
    org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1086)
    org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:659)
    org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223)
    org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1558)
    org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1515)
    java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
    java.lang.Thread.run(Thread.java:745)

Please take a look at branch https://github.com/apache/wicket/tree/pr-160-master and commit ebfa1bb

[martin-g]

X-Ref: Atmosphere/atmosphere#2140

[MarcGiffing]

I've currently have problems with the lookup of the atmopshere.xml in an embedded tomcat.
Maybe the deprecated methods should be updated with the update of the latest atmosphere version.

EventBus.java:

private static Broadcaster lookupDefaultBroadcaster()
    {
        BroadcasterFactory factory = BroadcasterFactory.getDefault();
        if (factory == null)
        {
            throw new WicketRuntimeException(
                "There is no Atmosphere BroadcasterFactory configured. Did you include the "
                    + "atmosphere.xml configuration file and configured AtmosphereServlet?");
        }

The BroadcasterFactory.getDefault(); is deprecated and instead you should use:
org.atmosphere.cpr.AtmosphereConfig.resourcesFactory()

It's only a hint...I'm not sure if its related to my problem.

https://github.com/Atmosphere/atmosphere/wiki/Getting-BroadcasterFactory-and-AtmosphereResourceFactory-with-2.2-and-newer

With the release of Atmosphere 2.2.0, the static getters BroadcasterFactory.getDefault() and AtmosphereResourceFactory.getDefault() were deprecated, and from 2.3+ they are completely removed.

Okay...the static getters are still there ... :)

[BugHunterPhilosopher]

Good evening,

Any news with this PR, please? I'd really like it to join the wicket-7.x branch.

Thanks in advance.

[martin-g]

Please try to make https://github.com/apache/wicket/tree/pr-160-master running againts latest Atmosphere version.
I've hit several issues with 2.4.x.

[martin-g]

@payou Please close this PR! Wicket team decided to discontinue the support for Wicket-Atmosphere (see https://issues.apache.org/jira/browse/WICKET-6305). Thanks!

[payou]

OK
Atmosphere is über complicated
So good luck with WebSocket