WICKET-6771 Performance issues with component metadata #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing component metadata
theigl
force-pushed
the
WICKET-6771-metadata-performance
branch
2 times, most recently
from
02a91f1
to
6b885e2
Compare
theigl
force-pushed
the
WICKET-6771-metadata-performance
branch
from
6b885e2
to
0547466
Compare
…a-performance # Conflicts: # wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a JMH benchmark that demonstrated performance issues with accessing component metadata.
The benchmark is executed by running the main method in
ComponentBenchmarks. It should be run 2-3 times to get reliable results.On my machine the results are:
I couldn't get to the root cause of the performance issues but the PR suggests a possible workaround: Using request-level flags that are checked before accessing component metadata.
https://issues.apache.org/jira/browse/WICKET-6771