Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WICKET-5446 Improve version matching in resource caching strategies #66

Closed
wants to merge 1 commit into from
Closed

Conversation

sfussenegger
Copy link

improves fix of WICKET-5263 as described in JIRA comment

@martin-g
Copy link
Member

Thanks!
I saw your comment in the ticket but I'm afraid such change cannot be done for Wicket 6.x.

You correctly did it against master branch.
I'll create a new ticket to not forget it.

@sfussenegger
Copy link
Author

I wasn't sure what would be preferred. Suggesting to reopen with a new Fix Version or creating a new ticket. This is my first patch since 1.4 (which I'm currently migrating off) so this semantic versioning stuff is quite new to me :) Please link the issue after you've created one.

@sfussenegger
Copy link
Author

@martin-g you may wanna look at WICKET-5441 too while you're at it.

@martin-g
Copy link
Member

Sure.

@martin-g
Copy link
Member

I've created https://issues.apache.org/jira/browse/WICKET-5446
Please rebase to latest master so I can apply this PR.

when the versionPrefix is contained in the original filename
- added getVersionPattern() to IResourceVersion
@sfussenegger
Copy link
Author

Done

@martin-g
Copy link
Member

https://issues.apache.org/jira/browse/WICKET-5446 is closed.
Please close this PR.

Thank you for your contributions!

@sfussenegger sfussenegger deleted the WICKET-5263 branch December 17, 2013 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants