Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WICKET-7094: Add missing scheme values of CSP #761

Merged
merged 2 commits into from
Jan 8, 2024
Merged

WICKET-7094: Add missing scheme values of CSP #761

merged 2 commits into from
Jan 8, 2024

Conversation

renoth
Copy link
Contributor

@renoth renoth commented Jan 7, 2024 •
edited by martin-g
Loading

WICKET-7094

@renoth renoth changed the title - Add missing constant values of CSP according to https://developer.m… - Add missing constant values of CSP Jan 7, 2024
@renoth renoth changed the title - Add missing constant values of CSP Add missing constant values of CSP Jan 7, 2024
@renoth
Copy link
Contributor Author

renoth commented Jan 7, 2024

See also https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/Sources#scheme-source

martin-g
martin-g requested changes Jan 8, 2024
View reviewed changes
Copy link
Member

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good but:

  1. we will need a JIRA ticket for the changelog
  2. it would be good to add some new unit tests

@renoth
Copy link
Contributor Author

renoth commented Jan 8, 2024

Ticket is https://issues.apache.org/jira/browse/WICKET-7094

@renoth renoth changed the title Add missing constant values of CSP Add missing scheme values of CSP Jan 8, 2024
@martin-g martin-g changed the title Add missing scheme values of CSP WICKET-7094: Add missing scheme values of CSP Jan 8, 2024
@martin-g martin-g merged commit 04347ba into apache:master Jan 8, 2024
3 checks passed
martin-g pushed a commit that referenced this pull request Jan 8, 2024
@renoth @martin-g
WICKET-7094: Add missing scheme values of CSP (#761)
46af493 
WICKET-7094:  Add missing constant values of CSP according to https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/Sources#scheme-source

---------

Co-authored-by: renoth <johannes@renoth.dev>
(cherry picked from commit 04347ba)
@martin-g
Copy link
Member

martin-g commented Jan 8, 2024

Thank you for the contribution, @renoth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-g martin-g martin-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@renoth @martin-g