WICKET-6890 Introduce strategy for class name debug output #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theigl
commented
Feb 9, 2024
theigl
commented
Feb 9, 2024
wicket-jmx/src/main/java/org/apache/wicket/jmx/DebugSettingsMBean.java
Outdated
Show resolved
Hide resolved
theigl
force-pushed
the
WICKET-6890-debug-strategy
branch
from
5ae5697
to
c60ef32
Compare
martin-g
reviewed
Feb 9, 2024
wicket-core/src/main/java/org/apache/wicket/settings/DebugSettings.java
Outdated
Show resolved
Hide resolved
wicket-core/src/main/java/org/apache/wicket/settings/DebugSettings.java
Outdated
Show resolved
Hide resolved
wicket-jmx/src/main/java/org/apache/wicket/jmx/DebugSettingsMBean.java
Outdated
Show resolved
Hide resolved
theigl
force-pushed
the
WICKET-6890-debug-strategy
branch
from
c60ef32
to
bb155b8
Compare
theigl
force-pushed
the
WICKET-6890-debug-strategy
branch
from
bb155b8
to
dd20a00
Compare
martin-g
approved these changes
Feb 28, 2024
wicket-core/src/main/java/org/apache/wicket/settings/DebugSettings.java
Outdated
Show resolved
Hide resolved
|
@theigl Do you need help here ? |
martin-g
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a strategy for outputting a container's class name for debugging purposes.
Up until 8bbf158,
ClassNameStrategy.HTML_COMMENTwas the default strategy. Since thenClassNameStrategy.TAG_ATTRIBUTEhas become the default and only option.For applications that strip Wicket tags during development, this means that there is currently no more debug output.