Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XERCESC-2208: Use cstdint and standard integer types #21

Merged
merged 5 commits into from Sep 22, 2021
Merged

XERCESC-2208: Use cstdint and standard integer types #21

merged 5 commits into from Sep 22, 2021

Conversation

rleigh-codelibre
Copy link
Contributor

@rleigh-codelibre rleigh-codelibre commented Jun 13, 2020

  • Unconditionally use <cstdint>. Also use <cstddef> and <cwchar>.
  • Remove Autoconf and CMake integer checks, along with some other unused header checks and defines present in Xerces_autoconf_config.hpp
  • Move constant type definitions out of Xerces_autoconf_config.hpp into XercesDefs.hpp
  • UTF16Ch and UCS4Ch are typedefs for char16_t and char32_t, so are now using the language types specifically intended for the purpose
  • XSValue now uses fixed-size integer types, so its behaviour will be the same across all platforms.

@rleigh-codelibre
Copy link
Contributor Author

Tested on additional 32-bit platform (Debian 10, GCC 8.3) and it builds without error, and XSValue and all the other tests are passing.

@boris-kolpackov
Copy link
Contributor

I tend to think this (and other similar changes) can only go into 4.0.0. Should we make master explicitly 4-series?

@rleigh-codelibre
Copy link
Contributor Author

Hi Boris,

I think that's a good idea, and I think that Scott would also prefer it as well from the current discussion.

Thanks,
Roger

@scantor
Copy link
Contributor

scantor commented Jun 15, 2020

I don't have any particular preference, but given that it's unlikely everything you might want to do will be possible without an API change, I'm sure it's simplest.

@rleigh-codelibre
Copy link
Contributor Author

I've done the version update to 4.0.0 on the master branch. If you're happy to proceed with this change, it should be OK to go in.

@rleigh-codelibre
Copy link
Contributor Author

Rebased against current master (no source changes). If there are no objections to merging, will merge later today.

@rleigh-codelibre rleigh-codelibre merged commit 12a3c84 into apache:master Sep 22, 2021
@rleigh-codelibre rleigh-codelibre deleted the xerces-XERCESC-2208_Use_cstdint branch September 22, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants