Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XERCESC-2229] IGXMLScanner::scanDocTypeDecl(): fix memory leak on exception #42

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Oct 28, 2021

The method can leak pubId and sysId when subsequent call to
fReaderMgr.skipPastSpaces() throws an exception (e.g. a
TranscodingException)

The method can leak pubId and sysId when subsequent call to
fReaderMgr.skipPastSpaces() throws an exception (e.g. a
TranscodingException)
@rouault rouault changed the title IGXMLScanner::scanDocTypeDecl(): fix memory leak on exception [XERCESC-2229] IGXMLScanner::scanDocTypeDecl(): fix memory leak on exception Oct 28, 2021
Copy link
Contributor

@rleigh-codelibre rleigh-codelibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Even, this looks good to me.

@rleigh-codelibre rleigh-codelibre merged commit ecdc077 into apache:master Nov 6, 2021
@scantor
Copy link
Contributor

scantor commented Oct 5, 2022

Applied to 3.2 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants