shutdown() function for CleanerThread #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosame
reviewed
Jun 10, 2021
| try { | ||
| ref = queue.remove(); | ||
| try { | ||
| while(!shutdownLatch.await(100, TimeUnit.MILLISECONDS)) { |
There was a problem hiding this comment.
Do you have a reasoning as to why 100ms?
There was a problem hiding this comment.
Not against a timeout, but 100ms looks way too small.
|
Not really. |
carlosame
reviewed
Jun 11, 2021
| throw td; | ||
| } catch (Throwable t) { | ||
| t.printStackTrace(); | ||
| } finally { |
There was a problem hiding this comment.
You should release the hatch at the finally block, before setting queue to null:
shutdownLatch.countDown();
|
@jjYBdx4IL I see that you modified the pull request after my comments, just wanted to point out that I'm not a Batik developer nor am I related to the ASF in any way. Thus, my comments do not represent any "official" statement from the Batik developers, the PMC nor the ASF. |
jjYBdx4IL
force-pushed
the
CleanerThreadInterrupt
branch
2 times, most recently
from
8ac91be
to
e0f777e
Compare
* de-initialize CleanerThread variables on thread shutdown * don't run CleanerThread as daemon
jjYBdx4IL
force-pushed
the
CleanerThreadInterrupt
branch
from
e0f777e
to
1a3a005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proper fix for:
https://issues.apache.org/jira/browse/BATIK-939
instead of using or suppressing interrupts, a simple CountDownLatch is used to check whether the thread should shut down or not.