BATIK-1318: NullPointerException in SAXSVGDocumentFactory.resolveEntity()

[stanio]

Suggested fix for BATIK-1318.

In 2014 the SAXSVGDocumentFactory class along with the dtdids.properties resource have been moved from org.apache.batik.dom.svg to org.apache.batik.anim.dom package:

• 412c7bb removed cyclic dependencies reported in BATIK-1098

However, the resources referenced in dtdids.properties are still in org.apache.batik.dom.svg package:

• batik-svg-dom/src/main/resources/org/apache/batik/dom/svg/resources/

This makes the following Class.getResource() return null and ultimately cause NPE:

xmlgraphics-batik/batik-anim/src/main/java/org/apache/batik/anim/dom/SAXSVGDocumentFactory.java

Lines 386 to 392 in 42f6965

	String localSystemId =
	dtdProps.getProperty(KEY_SYSTEM_ID +
	publicId.replace(' ', '_'));
	if (localSystemId != null && !"".equals(localSystemId)) {
	return new InputSource
	(getClass().getResource(localSystemId).toString());

I can see the overall issue has been partially addressed in f2dac46. I suggest further the dtdids.properties should be updated with absolute resource names.

[stanio]

Now that 04b46fd is checked into the main line, one may need to add (haven't tested it explicitly):

--add-opens org.apache.xmlgraphics.batik.svgdom/org.apache.batik.dom.svg.resources=org.apache.xmlgraphics.batik.anim

when using the --module-path vs. --class-path runtime configuration. This could be further addressed by more appropriate packaging. For example, SAXSVGDocumentFactory (and dtdids.properties) should likely reside in the batik-dom module, where the rest of the referenced resources are.