Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YETUS-1038. Disable jira and gitlab in action #7

Merged
merged 1 commit into from Oct 20, 2020
Merged

YETUS-1038. Disable jira and gitlab in action #7

merged 1 commit into from Oct 20, 2020

Conversation

aw-was-here
Copy link
Contributor

No description provided.

ndimiduk
ndimiduk approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No line break character needed?

@aw-was-here
Copy link
Contributor Author

No line break character needed?

Nope. YAML turns it into

"--plugins=all,-asflicense,-author,-findbugs,-gitlab, -golangcilint,-jira,-shelldocs"

test-patch appears to do the right thing (even with the extra space).

Thanks for the review, I'll merge this. :)

@aw-was-here aw-was-here merged commit dd507ad into apache:main Oct 20, 2020
@aw-was-here aw-was-here deleted the yetus-1035 branch October 20, 2020 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndimiduk ndimiduk ndimiduk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@aw-was-here @ndimiduk