YETUS-1057. Remove findbugs support

asf-site-src/source/documentation/in-progress/precommit/advanced.html.md

@@ -183,10 +183,10 @@ function personality_file_tests
   local filename=$1
 
   if [[ ${filename} =~ \.java$ ]]; then
-    add_test findbugs
     add_test javac
     add_test javadoc
     add_test mvninstall
+    add_test spotbugs
     add_test unit
   fi
 
@@ -255,7 +255,7 @@ or autodetermined by various means.  The `PROJECT_NAME` version takes precedence
 Personalities can set the base list of plug-ins to enable and disable for their project via the `personality_plugins` function. Just call it with the same pattern as the `--plugins` command line option:
 
 ```bash
-personality_plugins "all,-checkstyle,-findbugs,-asflicense"
+personality_plugins "all,-checkstyle,-spotbugs,-asflicense"
 ```
 
 This list is used if the user does not provide a list of plug-ins.

asf-site-src/source/documentation/in-progress/precommit/index.html.md

@@ -138,7 +138,6 @@ Language Support, Licensing, and more:
 * [buf](plugins/buf)
 * [checkmake](plugins/checkmake)
 * [checkstyle](plugins/checkstyle)
-* [FindBugs](plugins/findbugs)
 * [golangci-lint](plugins/golangcilint)
 * [hadolint](plugins/hadolint)
 * [jshint](plugins/jshint)

asf-site-src/source/documentation/in-progress/precommit/plugins/spotbugs.html.md

@@ -23,14 +23,11 @@ spotbugs
 
 # Category
 
-One or more of:
-
 Test
 
 # Description
 
-Runs the Java-based [SpotBugs](https://spotbugs.github.io/) utility or, in deprecated mode, the FindBugs utility.
-Only one of `spotbugs` or `findbugs` may be active at a time, with `spotbugs` taking precedent.
+Runs the Java-based [SpotBugs](https://spotbugs.github.io/) utility.
 
 # Environment Variables
 
@@ -42,8 +39,6 @@ Only one of `spotbugs` or `findbugs` may be active at a time, with `spotbugs` ta
 
 | Option | Notes |
 |:---------|:------|
-| `--findbugs-home==<dir>` | (DEPRECATED) FindBugs home directory. There is no default. |
-| `--findbugs-strict-precheck` | (DEPRECATED) Fail patch testing if `findbugs` determines a failure before even applying the patch |
 | `--spotbugs-home==<dir>` | SpotBugs home directory. There is no default. |
 | `--spotbugs-strict-precheck` | Fail patch testing if `spotbugs` determines a failure before even applying the patch |
 

asf-site-src/source/documentation/in-progress/precommit/robots/githubactions.html.md

@@ -79,7 +79,7 @@ Options currently supported are:
 | javahome | same as `--java-home`          | `/usr/lib/jvm/java-11-openjdk-amd64`  | [Java-related plug-ins](../../plugins/javac) |
 | patchdir | same as `--patch-dir`       | NONE  |[Usage Introduction](../../usage-intro) |
 | pip | same as `--pylint-pip`              | pip3  |  [pylint plug-in](../../plugins/pylint) |
-| plugins | same as `--plugins`             | all,-asflicense,-author,-findbugs,-gitlabcilint,-shelldocs  | [Usage Introduction](../../usage-intro) |
+| plugins | same as `--plugins`             | all,-asflicense,-author,-shelldocs  | [Usage Introduction](../../usage-intro) |
 | project | same as `--project`             | Auto-set based upon the repository name  | [Usage Introduction](../../usage-intro) |
 | pylint | same as `--pylint`               | pylint3  | [pylint plug-in](../../plugins/pylint) |
 | reapermode | same as `--reapermode`       | kill  | [Advanced Usage](../../advanced) |

asf-site-src/source/documentation/in-progress/precommit/usage-intro.html.md

@@ -205,7 +205,7 @@ You should see output similar to this:
 BUILDTOOLS:
   nobuild ant autoconf cmake gradle make maven
 TESTTYPES:
-  asflicense author cc checkmake checkstyle dupname golang golangcilint hadolint javac javadoc jshint markdownlint mvnsite pathlen perlcritic prototool pylint revive rubocop scalac scaladoc shellcheck shelldocs findbugs test4tests unitveto whitespace xml yamllint
+  asflicense author blanks buf cc checkmake checkstyle dupname golang golangcilint hadolint javac javadoc jshint markdownlint mvnsite pathlen perlcritic pylint revive rubocop scalac scaladoc shellcheck shelldocs test4tests unitveto xml yamllint
 BUGSYSTEMS:
   briefreport bugzilla github gitlab htmlout jira junit slack
 TESTFORMATS:
@@ -234,10 +234,10 @@ $ test-patch --plugins="all" <other options>
 `--plugins` also allows some basic "arithmetic":
 
 ```bash
-$ test-patch --plugins="all,-checkstyle,-findbugs" <other options>
+$ test-patch --plugins="all,-checkstyle,-spotbugs" <other options>
 ```
 
-This will enable all plug-ins for potential usage, except for `checkstyle` and `findbugs`.
+This will enable all plug-ins for potential usage, except for `checkstyle` and `spotbugs`.
 
 **NOTE: Many examples in this section will use `--plugins=all`. Users should set the `--plugins` option as appropriate.**
 

precommit/src/main/shell/plugins.d/ant.sh

@@ -111,9 +111,6 @@ function ant_modules_worker
   UNSUPPORTED_TEST=false
 
   case ${tst} in
-    findbugs)
-      modules_workers "${repostatus}" findbugs findbugs
-    ;;
     compile)
       modules_workers "${repostatus}" compile
     ;;
@@ -216,7 +213,6 @@ function ant_builtin_personality_file_tests
 
   if [[ ${filename} =~ \.java$ ]]; then
     add_test spotbugs
-    add_test findbugs
   fi
 }
 

precommit/src/main/shell/plugins.d/gradle.sh

@@ -228,6 +228,5 @@ function gradle_builtin_personality_file_tests
 
   if [[ ${filename} =~ \.java$ ]]; then
     add_test spotbugs
-    add_test findbugs
   fi
 }

precommit/src/main/shell/plugins.d/maven.sh

@@ -337,9 +337,6 @@ function maven_modules_worker
   UNSUPPORTED_TEST=false
 
   case ${tst} in
-    findbugs)
-      modules_workers "${repostatus}" findbugs test-compile findbugs:findbugs -DskipTests=true
-    ;;
     compile)
       modules_workers "${repostatus}" compile clean test-compile -DskipTests=true
     ;;
@@ -521,7 +518,6 @@ function maven_builtin_personality_file_tests
 
   if [[ ${filename} =~ \.java$ ]]; then
     add_test spotbugs
-    add_test findbugs
   fi
 }