YETUS-1206. upgrade golangci-lint to match bundled go 1.19 version (#294

)

precommit/src/main/shell/test-patch-docker/Dockerfile

@@ -204,11 +204,17 @@ RUN git clone \
 
 ####
 # golangci-lint (Multi-tool golang linter)
+#
+# NOTE: go must be installed prior to executing this block!
 ####
 FROM yetusbase as yetusgolangci
-ARG GOLANGCILINT_VERSION=1.45.2
+ARG GOLANGCILINT_VERSION=1.50.0
 SHELL ["/bin/bash", "-o", "pipefail", "-c"]
-RUN go install github.com/golangci/golangci-lint/cmd/golangci-lint@v$GOLANGCILINT_VERSION
+RUN curl -sSL \
+      https://github.com/golangci/golangci-lint/releases/download/v$GOLANGCILINT_VERSION/golangci-lint-$GOLANGCILINT_VERSION-"$(go env GOOS)"-"$(go env GOARCH)".tar.gz \
+      -o golangcilint.tar.gz \
+    && tar -xzf golangcilint.tar.gz -C /usr/local/bin --strip-components 1 \
+    && rm golangcilint.tar.gz
 
 ########
 #
@@ -411,7 +417,7 @@ RUN ln -s /opt/bats/bin/bats /usr/local/bin/bats
 
 COPY --from=yetusrevive /root/go/bin/* /usr/local/bin
 COPY --from=yetuscheckmake /tmp/checkmake/checkmake /usr/local/bin
-COPY --from=yetusgolangci /root/go/bin/* /usr/local/bin
+COPY --from=yetusgolangci /usr/local/bin/golangci-lint /usr/local/bin
 
 ####
 # YETUS CUT HERE