Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YETUS-1022. Get commit sha from github PR json #156

Merged
merged 1 commit into from Oct 12, 2020

Conversation

aw-was-here
Copy link
Contributor

  • includes some docs updates to reflect
    what is supported for github

@aw-was-here
Copy link
Contributor Author

FYI: I don't want to commit this until YETUS-1021 gets in so that it can validate the website changes.

@aajisaka
Copy link
Member

Thank you @aw-was-here
I'm testing the PR in apache/hadoop#2348

* includes some docs updates to reflect
  what is supported for github
@aw-was-here
Copy link
Contributor Author

Argh. Need to rebase to pick up #154's website checker action.

@aajisaka
Copy link
Member

The commit status is updated successfully in apache/hadoop#2348
image

@aw-was-here
Copy link
Contributor Author

Thanks @aajisaka! Now I just need to make sure the website bits are correct ...

@aajisaka
Copy link
Member

(This is not directly related to this issue)

Now the "Details" link is console.
I think it's better for developers to link to the report HTML (ex. https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2348/12/Yetus_20Report/) instead of the console. It can be discussed/implemented in a separate issue.

@aw-was-here
Copy link
Contributor Author

(This is not directly related to this issue)

Now the "Details" link is console.
I think it's better for developers to link to the report HTML (ex. ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2348/12/Yetus_20Report) instead of the console. It can be discussed/implemented in a separate issue.

It definitely needs to be a separare issue since it means mixing two separate plug-ins. There's no guarantee that htmlout's output is actually reachable either... for example, on here.

@aw-was-here
Copy link
Contributor Author

Thanks for the review. website changes passed, so I'm merging this in....

@aw-was-here aw-was-here merged commit 73bc655 into apache:main Oct 12, 2020
@aajisaka
Copy link
Member

Thank you @aw-was-here

@aw-was-here aw-was-here deleted the yetus1022 branch October 17, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants