Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1363] Dividing TestResourceProto to TestToProto and TestNewResourceFromProto #443

Closed
wants to merge 5 commits into from

Conversation

0yukali0
Copy link
Contributor

What is this PR for?

Adopting table-driven style and dividing TestResourceProto to TestToProto and TestNewResourceFromProto.
TestToProto focuses the correctness of resource.
TestNewResourceFromProto checks the equality between original resource and a copy from Proto.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1363

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #443 (e97cadd) into master (2d0e468) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   72.62%   72.63%   +0.01%     
==========================================
  Files          65       69       +4     
  Lines        9568     9941     +373     
==========================================
+ Hits         6949     7221     +272     
- Misses       2381     2470      +89     
- Partials      238      250      +12     
Impacted Files Coverage Δ
pkg/scheduler/objects/node_collection.go 93.23% <0.00%> (-2.26%) ⬇️
pkg/common/resources/resources.go 97.14% <0.00%> (-0.54%) ⬇️
pkg/scheduler/ugm/group_tracker.go 100.00% <0.00%> (ø)
pkg/scheduler/ugm/queue_tracker.go 84.84% <0.00%> (ø)
pkg/scheduler/ugm/user_tracker.go 100.00% <0.00%> (ø)
pkg/scheduler/ugm/manager.go 55.05% <0.00%> (ø)
pkg/scheduler/objects/queue.go 69.97% <0.00%> (+0.03%) ⬆️
pkg/scheduler/partition.go 75.21% <0.00%> (+0.42%) ⬆️
pkg/scheduler/objects/nodesorting.go 75.34% <0.00%> (+4.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@0yukali0 0yukali0 closed this Oct 25, 2022
@0yukali0 0yukali0 reopened this Nov 10, 2022
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
simple refactor

@wilfred-s wilfred-s closed this in 1b1a608 Nov 11, 2022
@0yukali0 0yukali0 deleted the YUNIKORN-1363 branch June 14, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants