Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1459] Use priority for application sorting #484

Closed
wants to merge 1 commit into from

Conversation

craigcondit
Copy link
Contributor

@craigcondit craigcondit commented Dec 15, 2022

What is this PR for?

Use priority when sorting application requests.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1459

How should this be tested?

Unit tests added.

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@craigcondit craigcondit self-assigned this Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #484 (729a1e5) into master (56eb307) will increase coverage by 0.06%.
The diff coverage is 93.22%.

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
+ Coverage   73.12%   73.18%   +0.06%     
==========================================
  Files          69       69              
  Lines       10455    10494      +39     
==========================================
+ Hits         7645     7680      +35     
- Misses       2558     2561       +3     
- Partials      252      253       +1     
Impacted Files Coverage Δ
pkg/scheduler/objects/sorters.go 97.00% <93.10%> (-2.22%) ⬇️
pkg/scheduler/objects/queue.go 73.74% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wilfred-s
Copy link
Contributor

This probably needs a rebase before we proceed.
First look at the code all looks good, just waiting with the approval until we have rebased.

@craigcondit
Copy link
Contributor Author

Rebased on latest master. Minor change to .golangci.yaml required to fix lint crashing with panic (seems related to the recent zap logger upgrade).

Copy link
Contributor

@manirajv06 manirajv06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@craigcondit craigcondit deleted the YUNIKORN-1459 branch December 19, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants