[YUNIKORN-2087] reinstate node utilisation rest endpoint #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node utilisation endpoint is required to be exposed for the dashboard to work after YUNIKORN-325 Moving the endpoint to /ws/v1/scheduler/node-utilization The endpoint will need to change as part of YUNIKORN-2088
craigcondit
reviewed
Nov 7, 2023
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
==========================================
+ Coverage 77.56% 77.69% +0.12%
==========================================
Files 80 80
Lines 13244 13317 +73
==========================================
+ Hits 10273 10346 +73
Misses 2650 2650
Partials 321 321
... and 3 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The node utilisation endpoint is required to be exposed for the dashboard to work after YUNIKORN-325
Moving the endpoint to /ws/v1/scheduler/node-utilization The endpoint will need to change as part of YUNIKORN-2088
What type of PR is it?
What is the Jira issue?
How should this be tested?
Dashboard fails to show without the fix
Deploy YuniKorn from master with the web UI from master needs to include fix from YUNIKORN-2087 also: dashboard works
Screenshots (if appropriate)
NA