Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YUNIKORN-2151 Report resource used by placeholder pods in the app su… #715

Closed
wants to merge 6 commits into from

Conversation

zhuqi-lucas
Copy link
Contributor

@zhuqi-lucas zhuqi-lucas commented Nov 14, 2023

…mmary

What is this PR for?

YUNIKORN-1385 reports resource usage of application upon its completion.

The app summary should also consider the placeholder pods, which can be timeout for default 15 mins, but we can't count the resource used by placeholder pods.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (af91716) 77.65% compared to head (6442970) 77.64%.
Report is 3 commits behind head on master.

Files Patch % Lines
pkg/scheduler/objects/application.go 88.46% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
- Coverage   77.65%   77.64%   -0.01%     
==========================================
  Files          80       80              
  Lines       13339    13344       +5     
==========================================
+ Hits        10358    10361       +3     
- Misses       2658     2660       +2     
  Partials      323      323              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits (one question actually).

pkg/scheduler/objects/application.go Outdated Show resolved Hide resolved
pkg/scheduler/objects/application_test.go Outdated Show resolved Hide resolved
@zhuqi-lucas
Copy link
Contributor Author

Hi @pbacsko , i addressed your comments and also fix all the time sleep for tracking resources.

@pbacsko
Copy link
Contributor

pbacsko commented Nov 15, 2023

@zhuqi-lucas as I mentioned in the JIRA, pls check TestFinishedTime. Thanks.

@zhuqi-lucas
Copy link
Contributor Author

@zhuqi-lucas as I mentioned in the JIRA, pls check TestFinishedTime. Thanks.

Addressed this, thanks @pbacsko !

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@pbacsko pbacsko closed this in c0140a9 Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants