[YUNIKORN-2539] Core: Add deadlock tracking feature #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #835 +/- ##
==========================================
- Coverage 79.40% 79.22% -0.18%
==========================================
Files 82 83 +1
Lines 11317 11361 +44
==========================================
+ Hits 8986 9001 +15
- Misses 2009 2036 +27
- Partials 322 324 +2 ☔ View full report in Codecov by Sentry. |
craigcondit
force-pushed
the
YUNIKORN-2539
branch
from
e8cc32b
to
70a7374
Compare
Replaces sync.{RW}Mutex with internal locking.{RW}Mutex implementations.
The new implementation wraps the go-deadlock library with logic to
conditionally enable deadlock detection based on the presence of
environment variables:
To enable the feature:
- DEADLOCK_DETECTION_ENABLED=true
To customize the timeout before potential deadlocks are logged (default
is 60 seconds):
- DEADLOCK_TIMEOUT_SECONDS=60
See https://github.com/sasha-s/go-deadlock for more details.
craigcondit
force-pushed
the
YUNIKORN-2539
branch
from
70a7374
to
9b2e15a
Compare
pbacsko
approved these changes
Apr 5, 2024
craigcondit
added a commit
that referenced
this pull request
Apr 5, 2024
Replaces sync.{RW}Mutex with internal locking.{RW}Mutex implementations.
The new implementation wraps the go-deadlock library with logic to
conditionally enable deadlock detection based on the presence of
environment variables:
To enable the feature:
- DEADLOCK_DETECTION_ENABLED=true
To customize the timeout before potential deadlocks are logged (default
is 60 seconds):
- DEADLOCK_TIMEOUT_SECONDS=60
See https://github.com/sasha-s/go-deadlock for more details.
Closes: #835
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Replaces sync.{RW}Mutex with internal locking.{RW}Mutex implementations. The new implementation wraps the go-deadlock library with logic to conditionally enable deadlock detection based on the presence of environment variables:
To enable the feature:
To customize the timeout before potential deadlocks are logged (default is 60 seconds):
See https://github.com/sasha-s/go-deadlock for more details.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2539
How should this be tested?
Added basic unit tests and benchmarks.
Impact
Performance impact is negligible when the feature is disabled (~ 4 ns per lock). When enabled, locks are considerably slower due to the tracking required; however even on a 5-year old laptop I still see ~ 800,000 locks per second. This should still be usable for short periods of diagnosing even relatively busy clusters.
Questions: