Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2593] Remove partition from Allocation and AllocationAsk #858

Closed
wants to merge 1 commit into from

Conversation

craigcondit
Copy link
Contributor

@craigcondit craigcondit commented Apr 26, 2024

What is this PR for?

Remove the partition name from the Allocation and AllocationAsk objects.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2593

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 77.04%. Comparing base (05bd6ef) to head (c9ca72d).

Files Patch % Lines
pkg/scheduler/context.go 0.00% 6 Missing ⚠️
pkg/scheduler/objects/application.go 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
- Coverage   77.04%   77.04%   -0.01%     
==========================================
  Files          97       97              
  Lines       11998    11989       -9     
==========================================
- Hits         9244     9237       -7     
+ Misses       2419     2418       -1     
+ Partials      335      334       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wilfred-s
Copy link
Contributor

-1 on this approach, see comment in the jira.
Not sure why we have partition anywhere in the scheduler objects we should just remove it from app, node, queue whatever has it and leave it at that.

The partition name is not required in Allocation and AllocationAsk, as it can
be found in other contexts. Remove it to make the objects smaller.
@craigcondit craigcondit changed the title [YUNIKORN-2593] Simplify partition name handling [YUNIKORN-2593] Remove partition from Allocation and AllocationAsk May 7, 2024
@craigcondit
Copy link
Contributor Author

-1 on this approach, see comment in the jira. Not sure why we have partition anywhere in the scheduler objects we should just remove it from app, node, queue whatever has it and leave it at that.

I've removed it from Allocation and AllocationAsk in this PR. If further removals are needed, we can address that in a followup.

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants