[YUNIKORN-2635] test coverage improvement: same priority case in sorter #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #871 +/- ##
==========================================
+ Coverage 77.08% 77.13% +0.04%
==========================================
Files 97 97
Lines 11989 11992 +3
==========================================
+ Hits 9242 9250 +8
+ Misses 2415 2411 -4
+ Partials 332 331 -1 ☔ View full report in Codecov by Sentry. |
pbacsko
reviewed
May 23, 2024
Comment on lines
302
to
303
| // apps should come back in order: 0, 2, 3, 1 | ||
| assertAppList(t, list, []int{0, 3, 1, 2}, "app-1 & app-3 allocated, app-3 high priority") |
There was a problem hiding this comment.
Nit: comment is inconsistent with the code
pbacsko
reviewed
May 23, 2024
| input["app-2"].SubmissionTime = input["app-3"].SubmissionTime | ||
| input["app-1"].SubmissionTime = input["app-3"].SubmissionTime | ||
| list = sortApplications(input, policies.FifoSortPolicy, false, nil) | ||
| assertAppList(t, list, []int{0, 2, 3, 1}, "fifo first, priority second") // 0, 3, 1, 2 |
There was a problem hiding this comment.
Comment vs code: 0,3,1,2 or 0,2,3,1? I'm not sure that we need a comment at all if it's obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Update priority cases to improve test coverage.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2635
How should this be tested?
make test
Screenshots (if appropriate)
Questions: