[YUNIKORN-2515] Add property event.RESTResponseSize to the batch event handler

[pbacsko]

What is this PR for?

Update the code with the property event.RESTResponseSize as per the design document.

What type of PR is it?

• - Bug Fix
• - Improvement
• - Feature
• - Documentation
• - Hot Fix
• - Refactoring

Todos

• - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2515

How should this be tested?

Screenshots (if appropriate)

Questions:

• - The licenses files need update.
• - There is breaking changes for older versions.
• - It needs documentation.

[pbacsko]

I think Test_fixedRule_ruleDAO needs to be corrected, the map iteration order sometimes changes.

[pbacsko]

Created #887 to fix the test case. Will rebase this PR as soon as that one gets merged.

[chia7712]

I have another idea of implementing this new property.

event.RESTResponseSize can be applied to EventSystemImpl and thus GetEventsFromID can pick up min(count, RESTResponseSize) to generate EventRecord. That is similar to requestCapacity and ringBufferCapacity WDYT?

yunikorn-core/pkg/events/event_ringbuffer.go

Line 104 in d46f216

func (e *eventRingBuffer) getEventsFromID(id uint64, count uint64) ([]*si.EventRecord, uint64, uint64) {

[pbacsko]

event.RESTResponseSize can be applied to EventSystemImpl and thus GetEventsFromID can pick up min(count, > RESTResponseSize) to generate EventRecord. That is similar to requestCapacity and ringBufferCapacity WDYT?

Hm... I'd rather keep this separate. This property concerns the REST output, I think it's better to handle it separately from the event system.

[chia7712]

@pbacsko thanks for updated PR. overall LGTM. one last comment :)

[chia7712]

How about reusing common.GetConfigurationUint?

[chia7712]

LGTM

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.69%. Comparing base (c6aca63) to head (06e769b).
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
+ Coverage   77.43%   77.69%   +0.25%     
==========================================
  Files          97       97              
  Lines       12132    12119      -13     
==========================================
+ Hits         9395     9416      +21     
+ Misses       2410     2379      -31     
+ Partials      327      324       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.