Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2673] Improve newFilter funtion's test coverage #893

Closed
wants to merge 2 commits into from

Conversation

SP12893678
Copy link
Contributor

What is this PR for?

Improve newFilter funtion's test coverage
Fix wrong message

What type of PR is it?

  • - Test

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2673

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.76%. Comparing base (a786feb) to head (3bfc45a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
+ Coverage   77.71%   77.76%   +0.04%     
==========================================
  Files          97       97              
  Lines       12119    12119              
==========================================
+ Hits         9418     9424       +6     
+ Misses       2378     2375       -3     
+ Partials      323      320       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko pbacsko self-requested a review June 18, 2024 13:37
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pbacsko pbacsko closed this in 5706b54 Jun 18, 2024
@SP12893678 SP12893678 deleted the YUNIKORN-2673 branch June 18, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants